jroachgolf84 commented on code in PR #67519:
URL: https://github.com/apache/airflow/pull/67519#discussion_r3303952513
##########
providers/elasticsearch/tests/unit/elasticsearch/hooks/test_elasticsearch.py:
##########
@@ -303,7 +303,7 @@ def test_get_df_by_chunks_hook_lineage(self,
mock_get_pandas_df_by_chunks, mock_
assert call_kw["sql"] == sql
assert call_kw["sql_parameters"] == parameters
-
@mock.patch("airflow.providers.elasticsearch.hooks.elasticsearch.Elasticsearch")
+ @mock.patch("elasticsearch.Elasticsearch")
Review Comment:
Just curious, why did you make this switch?
##########
providers/elasticsearch/src/airflow/providers/elasticsearch/hooks/elasticsearch.py:
##########
@@ -171,6 +170,8 @@ def __init__(
kwargs.pop("field_multi_value_leniency", None)
netloc = f"{host}:{port}"
self.url = parse.urlunparse((scheme, netloc, "/", None, None, None))
Review Comment:
nit: add a blank line before `from elasticsearch import Elasticsearch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
