kaxil commented on code in PR #67590:
URL: https://github.com/apache/airflow/pull/67590#discussion_r3310263628
##########
providers/alibaba/src/airflow/providers/alibaba/cloud/hooks/analyticdb_spark.py:
##########
@@ -29,13 +29,15 @@
GetSparkAppWebUiAddressRequest,
KillSparkAppRequest,
SubmitSparkAppRequest,
- SubmitSparkAppResponse,
)
from alibabacloud_tea_openapi.models import Config
from airflow.providers.common.compat.sdk import AirflowException, BaseHook
from airflow.utils.log.logging_mixin import LoggingMixin
+if TYPE_CHECKING:
+ from alibabacloud_adb20211201.models import SubmitSparkAppResponse
Review Comment:
No, not this of a change. What I meant is move imports where the module
hasn't already been imported.
In this case `alibabacloud_adb20211201.models` is already imported on L26,
so this change won't have any impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
