vincbeck commented on code in PR #66595:
URL: https://github.com/apache/airflow/pull/66595#discussion_r3312219014
##########
airflow-core/src/airflow/jobs/triggerer_job_runner.py:
##########
@@ -737,11 +737,19 @@ def _create_workload(
render_log_fname: Callable[..., str],
session: Session,
) -> workloads.RunTrigger | None:
+ # aip-93
Review Comment:
nit: not sure if those comments are very helpful
##########
airflow-core/src/airflow/triggers/base.py:
##########
@@ -297,6 +299,13 @@ class BaseEventTrigger(BaseTrigger):
supports_triggerer_queue: bool = False
+ def __init__(self, **kwargs):
+ super().__init__(**kwargs)
+
+ # Injected by the triggerer before run() is called; mirrors how
trigger_id is set
+ self.watched_assets: list[AssetUniqueKey] | None = None
+ self.asset_states: AssetStateAccessors | None = None
Review Comment:
Question here, is there any way we can merge them? Or maybe we can compute
`self.watched_assets` from `self.asset_states`? I am not entirely sure so I am
just asking. I want to avoid duplicate attributes which can lead to
inconsistency issues etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
