potiuk opened a new pull request, #341:
URL: https://github.com/apache/airflow-steward/pull/341
## Summary
- Branch protection on `main` cannot use patterns for required status check
names — GitHub's classic branch-protection and rulesets APIs both require
exact-match `context` strings, so each entry in the `pytest` matrix in
`tests.yml` previously needed its own line in `.asf.yaml`.
- That coupling caused two known issues:
- #340 renames `pytest (skill-validator)` → `pytest
(skill-and-tool-validator)` and cannot merge, because branch protection on
`main` still requires the old context name (which no longer runs in CI after
the rename).
- The `pytest (agent-isolation)` matrix entry added in #339 was never
added to `.asf.yaml` and is silently not gated.
- Add a `tests-ok` umbrella job in `tests.yml` that `needs:` the `pytest`
matrix and fails unless every matrix entry succeeded.
- Replace all `pytest (...)` entries in `.asf.yaml` with the single
`tests-ok` context. Adding, renaming, or removing matrix entries no longer
touches `.asf.yaml`.
## Follow-up
- #340 needs to drop its `.asf.yaml` hunk (the `skill-validator` →
`skill-and-tool-validator` rename) and rebase — the line is gone on `main`
after this PR merges.
## Test plan
- [ ] CI on this PR passes all pre-existing required checks (the seven
`pytest (<project>)` matrix entries still required by branch protection on
`main` until this PR merges).
- [ ] The new `tests-ok` job appears in the checks list and passes.
- [ ] After merge: #340 (once rebased) shows `tests-ok` as the single
pytest-related required check, and is mergeable when all matrix entries pass.
- [ ] After merge: subsequent matrix renames (e.g. another tool added) do
not require an `.asf.yaml` change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
