Miretpl commented on PR #67446: URL: https://github.com/apache/airflow/pull/67446#issuecomment-4557559329
> I am not 100% sure if this is a niece case to mount account token in this way. Not sure either regarding how often it is used, but I agree with the docs which we have regarding that feature: 1. https://airflow.apache.org/docs/helm-chart/stable/service-account-token-examples.html#overview 2. https://airflow.apache.org/docs/helm-chart/stable/service-account-token-examples.html#high-security-environment > Code-wise it is looking good but I am not 100% confident it should be added to main line---- or if we rather should take both scheduler as well as cleanup consistently out into a Kustomize layer. For now, I would add it to both. During discussions regarding 2.0, we agreed that we will keep some in the core chart and enhancing security will be possible via Kustomize, but as the Kustomize CI setup is in progress, I would, for now, go with the old way. > Opinions from other maintainers? Not a maintainer, but these are my 2c 😄 > If merged, probably needs a back-port to 1-2x-line? Yup, I would add it there too, as it basically improves consistency within the chart, which we also discussed during 2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
