SameerMesiah97 commented on code in PR #67601:
URL: https://github.com/apache/airflow/pull/67601#discussion_r3314787160
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/dag_runs.py:
##########
@@ -153,6 +153,14 @@ def trigger_dag_run(
"message": f"A run already exists for Dag '{dag_id}' with
run_id '{run_id}'",
},
)
+ except ValueError as e:
Review Comment:
Catching all instances of `ValueError` is a bit too broad. Since it wraps
full `trigger_dag` invocation, this could convert unrelated internal
`ValueErrors` into 400 responses and mask real server-side issues.
Could you elaborate more on the scenarios under which you expected to
encounter a `ValueError`? Maybe it is better to narrow this to that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
