Revanth14 commented on code in PR #67626:
URL: https://github.com/apache/airflow/pull/67626#discussion_r3315549984
##########
providers/dbt/cloud/tests/unit/dbt/cloud/operators/test_dbt.py:
##########
@@ -210,7 +210,8 @@ def
test_execute_deferrable_does_not_pass_execution_timeout_to_defer(
execution_timeout=timedelta(seconds=3),
)
- dbt_op.execute(MagicMock())
+ with patch("airflow.providers.dbt.cloud.operators.dbt.time.time",
return_value=1000.0):
+ dbt_op.execute(MagicMock())
Review Comment:
Thanks, that makes sense. I had changed this while initially trying to
assert the exact wall-clock deadline values passed to the trigger, but I agree
that made this test less focused.
I restored this test to its original intent: verifying `defer(timeout=None)`
behavior and that the trigger receives deadline values using `ANY`. The
clock-specific assertion is now covered by the new trigger regression test
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
