andreahlert commented on code in PR #354: URL: https://github.com/apache/airflow-steward/pull/354#discussion_r3316149857
########## tools/spec-loop/AGENTS.md: ########## @@ -28,7 +28,7 @@ Run the spec's own **Validation** block first. General checks: ```bash # Validate skill definitions (frontmatter, links, placeholders) -uv run --project tools/skill-validator --group dev skill-validate +uv run --project tools/skill-and-tool-validator --group dev skill-and-tool-validate Review Comment: This same rename is missing from `tools/skill-evals/evals/setup-override-upstream/step-6-pr-confirm/fixtures/case-1-shows-all-sections/report.md:25` (`- [ ] Ran \`skill-validate\` — passes.`). Issue #351 acceptance criterion #1 (`git grep` returns no hits) is not met until that fixture is updated or its non-update is justified. The issue called it out explicitly under "Two spots need judgement, not blind replace." ########## tools/spec-loop/specs/meta-and-quality-tooling.md: ########## @@ -8,7 +8,7 @@ kind: feature mode: infra source: > README.md § Skill families (utilities) and AGENTS.md § Reusable skills. - Implemented by tools/skill-validator/, tools/skill-evals/, + Implemented by tools/skill-and-tool-validator/, tools/skill-evals/, Review Comment: Prose change here is correct. Reminder from the issue: after updating the `setup-override-upstream` fixture, re-run `uv run --project tools/skill-evals skill-eval tools/skill-evals/evals/setup-override-upstream/` and confirm `expected.json` still matches. `expected.json` for `case-1-shows-all-sections` does not literally contain `skill-validate`, so the update is most likely safe, but please verify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
