amoghrajesh opened a new pull request, #67641:
URL: https://github.com/apache/airflow/pull/67641
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Observed this failure:
```
================================================================================================
FAILURES
================================================================================================
_______________________________________________________________________
TestSnowflakeSqlApiHook.test_wait_for_query_timeout_error
________________________________________________________________________
providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py:1266:
in test_wait_for_query_timeout_error
assert sleep_mock.call_count == 3
E AssertionError: assert 0 == 3
E + where 0 = <MagicMock name='sleep' id='281320323411984'>.call_count
```
Example:
https://github.com/apache/airflow/actions/runs/26564368176/job/78257418836
The test mocks `time.time` with a fixed side-effect list. Additional
`time.time()` calls made by change between start_time assignment and the
timeout check consume values from the list, causing the elapsed-time arithmetic
to exceed the timeout immediately on the first iteration itself.
Proposing to make it more stable by replacing the `time.time` mock approach
with the `time_machine` pytest fixture `(move_to(0, tick=False))`. The frozen
clock isolates the test from any incidental `time.time()` calls in the
surrounding environment. The `time.sleep` mock advances the frozen clock
explicitly so the timeout triggers after exactly 3 polls. Also removes the
redundant `assert time_mock.call_count >= 3`, which is covered by
`get_sql_api_query_status.call_count == 4` anyways
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
