kaxil commented on code in PR #64571: URL: https://github.com/apache/airflow/pull/64571#discussion_r3317834465
########## task-sdk/docs/api.rst: ########## @@ -239,10 +239,29 @@ Partition Mapper .. autoapiclass:: airflow.sdk.StartOfYearMapper +.. autoapiclass:: airflow.sdk.RollupMapper Review Comment: Noticing the AIP-76 wiki and the code have drifted on naming -- the [AIP spec](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311626969) uses `PartitionByInterval` / `PartitionBySequence` / `PartitionByProduct` / `PartitionAtRuntime`, but the shipped surface here is `CronPartitionTimetable` / `PartitionedAssetTimetable` / `StartOfDayMapper` / `RollupMapper` / `ProductMapper` / `AllowedKeyMapper` / `ChainMapper`. Not a code concern but external readers landing on the AIP and searching for `PartitionByInterval` won't find anything in `airflow.sdk`. The May 2026 management deck even has a typo carried over (`CronPartitionedTimetable` -- doesn't exist). Probably worth a follow-up to either refresh the AIP wiki against the shipped names + amendment, or add a mapping note somewhere visible. cc TP, Wei since they're owning this AIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
