pierrejeambrun opened a new pull request, #67646:
URL: https://github.com/apache/airflow/pull/67646

   ## Symptom
   
   Opening a Clear or Mark-as-success/failed dialog on a Dag Run or task
   instance and closing it without confirming leaves the page unable to
   receive any click (scroll still works). Only a hard refresh recovers.
   
   ## Root cause
   
   #66225 (May 5, 2026) bumped ``@chakra-ui/react`` ``3.34.0 → 3.35.0``,
   which pulled in ``@ark-ui/react`` ``5.34.1 → 5.36.2``. From the Ark
   ``5.36.0`` release notes (2026-04-10):
   
   > **Dialog / Drawer**: Avoid setting inline ``pointer-events`` when
   > modal, letting the dismissable layer manage it.
   
   Before 5.36, the lock was an inline style on the dialog DOM so it
   disappeared on unmount. After 5.36, the **dismissable layer** owns
   the lock and only releases it when the close transition completes.
   
   Several callers in this codebase mount their dialog with
   ``{open ? <Dialog/> : undefined}`` (introduced by #47071, Feb 2025).
   That yanks the component out the moment ``open`` flips to ``false``
   — before the close transition fires. With the new Ark teardown the
   ``pointer-events: none`` overlay stays on ``document``.
   
   That pattern was accidentally safe with the old Ark for ~14 months;
   the bump is what flipped it from working to broken.
   
   ## Fix
   
   - Revert #66225.
   - Cap ``@chakra-ui/react`` at ``~3.34.0`` (patch only) so dependabot
     can't reach the same minor again.
   - Add a ``// @chakra-ui/react`` warning in ``package.json`` so the
     next contributor trying to upgrade re-checks every conditional
     ``{open ? <Dialog/> : undefined}`` site first.
   
   ## Follow-up
   
   The underlying conditional-mount pattern is the actual fragile part —
   rewriting those sites to always-render the dialog (and gating any
   expensive queries with ``enabled: open``) would let us pick up Chakra
   3.35+ safely. That's in flight on PR #67645 / branch
   ``fix/clear-mark-modal-unresponsive`` and can be merged after this
   one if we want to bump again later. This PR is the safe minimal
   revert to restore the page on ``main``.
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.7)
   
   Generated-by: Claude Code (Opus 4.7) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to