seanghaeli commented on PR #66379:
URL: https://github.com/apache/airflow/pull/66379#issuecomment-4566203747

   Addressed all review feedback:
   - Ferruzzi nit: removed the redundant docstring text from `wait()`
   - Ramitkataria: changed `id=self.id` → `callback_id=self.id` in the log field
   - Ramitkataria: `test_wait_calls_upload_logs_after_subprocess_completes` 
already covers that `wait()` calls `_upload_logs()` after subprocess exits
   - Eladkal: removed the warning (resolved in earlier commit)
   
   All threads now have replies. CI is running on the latest commit.
   
   ---
   Drafted-by: Claude Code (claude-sonnet-4-6); reviewed by @seanghaeli before 
posting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to