shahar1 commented on code in PR #67355:
URL: https://github.com/apache/airflow/pull/67355#discussion_r3319387675
##########
providers/google/tests/system/google/cloud/gen_ai/example_gen_ai_generative_model_tuning.py:
##########
@@ -50,8 +50,12 @@
from airflow.providers.google.common.utils.get_secret import get_secret
-def _get_actual_model(key) -> str:
+def _get_actual_model(key, use_hardcoded_model=True) -> str:
source_model: str | None = None
+ if use_hardcoded_model:
+ print("Use hardcoded model")
+ source_model = "gemini-2.5-flash-lite"
+ return source_model
Review Comment:
Defaulting `use_hardcoded_model=True` makes everything afterwards dead code,
which will be unclear to users who use this code as an example.
Please add an inline documentation (if it's not going to change any time
soon, I'd even consider removing the entire `_get_actual_model` and use the
hardcoded model instead).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
