kaxil commented on code in PR #1546:
URL: https://github.com/apache/airflow-site/pull/1546#discussion_r3319613520
##########
landing-pages/site/layouts/blog/list.html:
##########
@@ -19,10 +19,11 @@
{{ define "main" }}
<div class="no-width-restriction">
- <h2 class="page-header">Blog</h2>
+ <h1 class="page-header">Blog</h1>
<form class="search-form" method="get" action="/blog">
Review Comment:
`landing-pages/site/layouts/taxonomy/tag.html` has the identical search
input/button block (lines 25-26) but wasn't touched in this PR. The
`/blog/tags/<tag>/` pages will still hit the same Lighthouse issues this change
resolves, and the `<h2 class="page-header">Blog</h2>` there is also unchanged.
Worth updating it alongside `blog/list.html` since they share the URL space.
##########
landing-pages/site/assets/scss/main-custom.scss:
##########
@@ -60,36 +60,124 @@
@import "survey";
@import "suggest-change";
+/* Override Bootstrap's default --bs-code-color (#d63384, 4.2:1 vs white) with
an
+ accessible shade. Using `html` (specificity 0,0,1) so that the dark-mode
override
+ in _colors.scss ([data-bs-theme="dark"], specificity 0,1,0) always wins. */
+html {
+ --bs-code-color: #5a1039;
+}
+
/* Accessibility: .btn-filled uses #017cee (cerulean-blue) background with
white text.
WCAG AA requires 4.5:1; #017cee gives ~4.1:1. Override the button
background with
a slightly darker shade (#016bdb) that achieves 4.7:1 while staying
brand-adjacent. */
+button.btn-filled,
.btn-filled {
- background-color: #016bdb;
- border-color: #016bdb;
+ background-color: #0052a3;
Review Comment:
Several raw hex literals (`#0052a3`, `#0157b8`, `#005ebc`, `#016bdb`,
`#0072e3`) are introduced here and in `_blog-page.scss`. The codebase
convention is `map-get($colors, cerulean-blue)` via `_colors.scss`. Worth
adding the accessible shades as named entries in the `$colors` map so the
palette lives in one place. Otherwise the next palette change has to chase ~10
hardcoded spots.
##########
landing-pages/site/layouts/blog/baseof.html:
##########
@@ -23,12 +23,13 @@
{{ partial "head.html" . }}
</head>
<body class="td-{{ .Kind }}">
+<a href="#main-content" class="skip-link">Skip to main content</a>
Review Comment:
Skip-link was added to blog/community/docs/meetups/use-cases/_default baseof
files but not to `taxonomy/baseof.html`, so `/blog/tags/<tag>/` pages render
without it (and without `id="main-content"` on `<main>`). Either update
`taxonomy/baseof.html` in the same PR or note it as an explicit follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
