o-nikolas commented on code in PR #67658:
URL: https://github.com/apache/airflow/pull/67658#discussion_r3319959670
##########
airflow-core/src/airflow/serialization/encoders.py:
##########
@@ -198,9 +198,10 @@ def encode_asset_like(a: BaseAsset | SerializedAssetBase)
-> dict[str, Any]:
d["access_control"] = ac
else:
# Asset stores access_control as an AssetAccessControl
instance.
- if ac.producer_teams or not ac.allow_global:
+ if ac.producer_teams or ac.consumer_teams or not
ac.allow_global:
d["access_control"] = {
"producer_teams": ac.producer_teams,
+ "consumer_teams": ac.consumer_teams,
Review Comment:
Do we really need this nesting and guard for non-default values? If `ac`
always as the defaults we can just pass them through here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
