amoghrajesh commented on code in PR #65991:
URL: https://github.com/apache/airflow/pull/65991#discussion_r3322401640
##########
providers/apache/spark/tests/unit/apache/spark/hooks/test_spark_submit.py:
##########
@@ -1036,6 +1047,26 @@ def test_yarn_process_on_kill(self, mock_popen,
mock_renew_from_kt):
in mock_popen.mock_calls
)
+
@patch("airflow.providers.apache.spark.hooks.spark_submit.subprocess.Popen")
+ def test_legacy_on_kill_skips_yarn_cli_when_submit_sp_already_exited(self,
mock_popen):
+ """Regression guard for #65991: when `yarn_track_via_rm_api=False`
(legacy
Review Comment:
```suggestion
"""Regression guard when `yarn_track_via_rm_api=False` (legacy
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
