sejal-gupta-ksolves commented on code in PR #67636:
URL: https://github.com/apache/airflow/pull/67636#discussion_r3322778364
##########
airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx:
##########
@@ -31,14 +31,18 @@ export const FieldDateTime = ({
}: FlexibleFormElementProps & InputProps) => {
const { disabled, paramsDict, setParamsDict } = useParamStore(namespace);
const param = paramsDict[name] ?? paramPlaceholder;
+ const isTime = rest.type === "time";
+ const normalizeTime = (value: string) => (isTime &&
/^\d{2}:\d{2}$/u.test(value) ? `${value}:00` : value);
Review Comment:
Makes total sense. I added it originally as an extra fallback, but since
setting step handles this natively across modern browsers, it's definitely
redundant. I'll drop the normalization function completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
