ed-kyu opened a new pull request, #67689:
URL: https://github.com/apache/airflow/pull/67689
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
### Description
Resolves the long-standing TODO in `OracleHook.get_conn` to map the
connection `extra` **mode**/**purity** strings via the `oracledb.AuthMode` and
`oracledb.Purity` enums, replacing the hand-written `if/elif` chains.
### Key changes
* **Enum mapping:** the connection extra `mode`/`purity` string is now
resolved against the matching `AuthMode`/`Purity` enum member by name
(case-insensitive), collapsing two `if/elif` chains into a single `getattr`
lookup each.
* **Minimum bump:** `oracledb.AuthMode`/`oracledb.Purity` were introduced in
python-oracledb **2.3**, so the floor is raised from `2.0.0` to `2.3.0` (a
minor release within the same major).
* **Wider coverage:** matching now covers every `AuthMode`/`Purity` value
instead of the previously hard-coded subset.
### Compatibility
The legacy `AUTH_MODE_*` / `PURITY_*` module constants are aliases of these
enum members, so resolved connection values are unchanged. `None` is compared
explicitly because `Purity.DEFAULT` is `0` and a truthiness check would drop it.
> If raising the `oracledb` floor is undesirable, the same de-duplication
can be achieved without a bump via `getattr(oracledb, f"AUTH_MODE_{name}")` on
the legacy constants — happy to switch if preferred.
### Verification
* `prek` (ruff, pre-commit hooks): passed
* Existing `test_get_conn_mode` / `test_get_conn_purity` and the full
`test_oracle.py` hook suite (55 tests): passed unchanged
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes
Generated-by: Claude Code (Opus 4.8) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
