andreahlert commented on PR #163: URL: https://github.com/apache/airflow-steward/pull/163#issuecomment-4575877105
> Re-look since my May 15 approval: the substantive iteration with @justinmclean on Steps 12/13/14 is now landed in the branch — flowchart has `S11 → S12`, `S11 → S13`, `S11 → S14` as three independent terminals (no S12→S13 / S14→S13 edges), and the stateDiagram has `announced → archived`, `announced → audited`, `announced → bumped` all terminating at `[*]`. Both match what Justin asked for in his May 25 follow-up. > > The 10-skill family spec is well-grounded: the four cross-cutting boundaries (especially Boundary 1 — _agent never holds the RM's signing key_) match the `security-cve-allocate` pattern of "emit paste-ready commands, human runs them" and slot cleanly into RFC-AI-0004 Principle 1. The 3-dimension backend abstraction (`release_dist_backend` / `release_approval_mechanism` / `release_announce_backend`) makes non-ASF adopters first-class from day one. Approve from me on the substance. > > ### One thing left before merge: rebase > The branch is **25 commits behind `main`** and the conflicts in `README.md` (families table) and `docs/modes.md` (modes table) aren't mechanical — `main` evolved while this PR sat: > > * Triage row count moved from "10 shipping + 4 proposed" → **13** > * Mentoring moved from `proposed` (0 skills) → **`experimental`** (1 skill) > * Pairing moved from `proposed` (0 skills) → **`experimental`** (1 skill) > * Drafting count moved from "1 shipping + 6 proposed" → **2** > > These need composing with this PR's release-management additions to each row — not just an `ours` / `theirs` resolution. Same shape as the conflict I flagged in the earlier bulk-rebase session. Best done by you since the right composition depends on exactly how you want `release-management` framed alongside the post-update other-mode counts. > > Once rebased, branch is mergeable. > > > _This review was drafted by an AI-assisted tool and confirmed by an Apache Steward > > maintainer. The maintainer approving this PR has read the findings and signed off. > > If something feels off, please reply on the PR and a maintainer will follow up._ > > _More on how Apache Steward handles maintainer review:_ > > [CONTRIBUTING.md](https://github.com/apache/airflow-steward/blob/main/CONTRIBUTING.md). Done. Could you TAL? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
