Lee-W commented on PR #64571: URL: https://github.com/apache/airflow/pull/64571#issuecomment-4581243998
Hey @dstandish , thanks for reviewing. a few responses to the questions > Could we go with the dedicated regexes for now and add generality if/when a custom mapper actually needs it? The regex compiler was added per @uranusjr's review: without it, a custom output_format forces the user to also override decode_downstream, which TP found surprising. Hardcoding _WEEK_RE / _QUARTER_RE saves the ~120 lines but is not that users friendly > is the rollback-survival guarantee worth the machinery for v1, or would a plain log line do? Agree it might not worth the machinery for v1. The only reason I added it was for better discoverability. I can drop both to plain self.log and add it back if someone asks it. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
