Vamsi-klu commented on PR #67764: URL: https://github.com/apache/airflow/pull/67764#issuecomment-4581689236
Gentle ping for SME eyes when you have a moment, @Lee-W @uranusjr 🙏 Small scheduler fix for #62929: `[scheduler] use_job_schedule=False` was gating the entire `_create_dagruns_for_dags`, so it silently disabled asset- and partitioned-asset-triggered runs too — not just cron scheduling. The gate now wraps only the time-based `_create_dag_runs(non_asset_dags, …)` path, matching the documented behavior. @Lee-W — you reviewed the earlier (now closed-for-inactivity) #62931 and called the approach "a valid one", so flagging this here. Includes three regression tests (asset, partition, and a flag-on companion) plus a `best-practices.rst` "Disable the scheduler" doc correction. Thanks! --- Drafted-by: Claude Code (Opus 4.8) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
