amoghrajesh commented on code in PR #67769:
URL: https://github.com/apache/airflow/pull/67769#discussion_r3328378375
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_run.py:
##########
@@ -569,7 +569,7 @@ def __init__(
def _validate_inputs(self):
missing_fields = [k for k in ["project_id", "region", "service_name"]
if not getattr(self, k)]
if not self.project_id or not self.region or not self.service_name:
- raise AirflowException(
+ raise RuntimeError(
Review Comment:
Same here?
##########
providers/google/src/airflow/providers/google/cloud/operators/cloud_run.py:
##########
@@ -487,7 +487,7 @@ def __init__(
def _validate_inputs(self):
missing_fields = [k for k in ["project_id", "region", "service_name"]
if not getattr(self, k)]
if not self.project_id or not self.region or not self.service_name:
- raise AirflowException(
+ raise RuntimeError(
Review Comment:
More of a ValueError?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
