potiuk commented on code in PR #67698:
URL: https://github.com/apache/airflow/pull/67698#discussion_r3329116229


##########
airflow-core/src/airflow/ui/public/i18n/locales/de/common.json:
##########
@@ -267,6 +267,9 @@
   },
   "task_one": "Task",
   "task_other": "Tasks",
+  "taskGroup": {

Review Comment:
   This is really way better to leave it to the translation owners, I think - 
with this one you need to get everyone, in every language to sign-off their 
language, otherwise you have no idea if it makes any sense. And if you don't 
get those reviewes - then you are becoming responsible for what's merged. That 
breaks "human" responsibility for translation.
   
   We tried it before (I did) and I closed my attempt - because waiting time 
for all the people who are signed up as translators was just taking too long. I 
really think it's better to keep the current translation ownership and leave it 
to the translators who are responsible for their language to drive it.
   
   It's also much abetter in general to group translations "per language" in 
PRs not "per single thing added" - if we do it less frequently and have enough 
of a ping before we release, the translations will be done for bigger set of 
changes - sometimes related, but added over a series of PRs - and only when you 
see a group of such changes you might come up with a good translation. approach.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to