SameerMesiah97 commented on code in PR #67524:
URL: https://github.com/apache/airflow/pull/67524#discussion_r3329203987


##########
providers/amazon/tests/system/amazon/aws/example_dms.py:
##########
@@ -374,6 +375,24 @@ def delete_security_group(security_group_id: str, 
security_group_name: str):
     )
     # [END howto_operator_dms_stop_task]
 
+    # [START howto_operator_dms_modify_task]
+    modify_task = DmsModifyTaskOperator(
+        task_id="modify_task",
+        replication_task_arn=task_arn,
+        table_mappings={
+            "rules": [
+                {
+                    "rule-type": "selection",
+                    "rule-id": "1",
+                    "rule-name": "1",
+                    "object-locator": {"schema-name": "%", "table-name": "%"},
+                    "rule-action": "include",
+                }
+            ]
+        },
+    )
+    # [END howto_operator_dms_modify_task]

Review Comment:
   I think it would be better to move this new task after `await_task_stop`. 
The operator requires the task to be in a modifiable state (`STOPPED` is one of 
them) before it is executed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to