sridhar-3009 opened a new pull request, #67796:
URL: https://github.com/apache/airflow/pull/67796
## Summary
Resolves #67647.
Ark UI 5.36 moved `pointer-events` cleanup from an inline DOM style to the
dismissable layer's close-transition callback. Dialogs that were conditionally
mounted (`{open ? <Dialog/> : undefined}`) unmounted before that transition
ran, leaving `pointer-events: none` permanently stuck on `document` — every
button/link click was silently swallowed until a hard refresh.
## Root cause
The conditional mount pattern was intentional: unmounting reset `useState`
(note, selectedOptions, etc.) so re-opening the dialog showed the server value,
not the user's uncommitted input. Ark UI 5.36 made this pattern incompatible
with the new cleanup approach.
## Fix
**Buttons** — remove the `open` guard; always render the dialog:
```tsx
// before
{open ? <ClearRunDialog ... /> : undefined}
// after
<ClearRunDialog ... />
```
**Dialogs** — add `useEffect` to reset local state when `open` goes `false`:
```tsx
useEffect(() => {
if (!open) {
setNote(dagRun.note);
setSelectedOptions(["existingTasks"]);
}
}, [open, dagRun.note]);
```
This preserves the note-reset behaviour (#47071) while letting the dialog
drive its own close transition.
## Affected files
- `Clear/Run/ClearRunButton.tsx` + `ClearRunDialog.tsx`
- `Clear/TaskInstance/ClearTaskInstanceButton.tsx` +
`ClearTaskInstanceDialog.tsx`
- `MarkAs/Run/MarkRunAsButton.tsx` + `MarkRunAsDialog.tsx`
- `MarkAs/TaskInstance/MarkTaskInstanceAsButton.tsx` +
`MarkTaskInstanceAsDialog.tsx`
- `pages/TaskInstance/Header.tsx`
- `package.json`: `~3.34.0` → `^3.35.0`
- `CONTRIBUTING.md`: remove now-resolved caveat section
## Verification checklist
- [ ] Open any Clear/Mark-as dialog; cancel via X, Escape, or backdrop
click; confirm the rest of the page remains clickable
- [ ] Reopen the same dialog; confirm the note field shows the run/TI server
value
- [ ] Confirm a clear/mark-as action; close success dialog; confirm page is
still clickable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
