SameerMesiah97 commented on code in PR #66220: URL: https://github.com/apache/airflow/pull/66220#discussion_r3330430061
########## providers/elasticsearch/tests/unit/elasticsearch/utils/test_sql.py: ########## Review Comment: I agree that some of the tests share the same structure for the input paramters but the pagination/max_rows scenarios require substantially different response payloads and expectations. I considered parametrizing the tests in the manner you suggested but I felt it made the tests harder to understand. If you still feel strongly about it, I can go ahead and paramerize the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
