amoghrajesh opened a new pull request, #67835:
URL: https://github.com/apache/airflow/pull/67835
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes: claude sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### What?
The Core API routes for task and asset state (`PUT, PATCH, DELETE`) called
`get_state_backend()` to perform writes. If a custom backend is configured
(e.g. an S3-backed state store), these admin/operator API calls would route
through the external backend instead of the metadata DB — reading from and
writing to external storage rather than the canonical DB record.
The Core API is an admin interface and must always operate on DB state,
regardless of what backend workers use. This is consistent with how the XCom
Core API works — it queries BaseXCom directly and never calls through the XCom
backend.
### Current behaviour
`set_task_state`, `patch_task_state`, `delete_task_state`,
`clear_task_state`, `set_asset_state`, `delete_asset_state`, and
`clear_asset_state` all called `get_state_backend().xyz(...)`. With the default
`MetastoreStateBackend` this was a no-op, but with a custom backend configured
these routes would silently operate on the wrong storage layer.
### Proposed change
Replace `get_state_backend()` with a module-level `MetastoreStateBackend()`
instance in both Core API route files. All write/delete operations now go
directly to the DB unconditionally. Read operations (GET, LIST) were already
DB-direct and are unchanged.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
