henry3260 commented on code in PR #67550:
URL: https://github.com/apache/airflow/pull/67550#discussion_r3336692203
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py:
##########
@@ -410,6 +410,41 @@ def test_should_raises_403_unauthorized(self,
unauthorized_test_client):
response = unauthorized_test_client.get("/importErrors")
assert response.status_code == 403
+
@mock.patch("airflow.api_fastapi.core_api.routes.public.import_error.get_auth_manager")
Review Comment:
Could we add one more regression test for offset pagination?
For example, create two import-error files where the first file maps to
multiple Dags, then call
`/importErrors?offset=1&limit=1` and assert that the response returns the
second import-error object. This would guard against pagination being applied
to joined rows instead of distinct import errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
