sjyangkevin commented on PR #67449: URL: https://github.com/apache/airflow/pull/67449#issuecomment-4596568132
Hi @ferruzzi , I am still working on resolving the compatibility issue and also looking into the trade-off for the feedback (https://github.com/apache/airflow/pull/67449#discussion_r3300411893) After creating the `CommandType` according to the ECS implementation, it seems like we need to do a `cast` on the following (`args=list(cast("Sequence[str]", command))`) and also when constructing the pod for the callback (`callback_workload = cast("ExecuteCallback", next_job.command[0])`): https://github.com/apache/airflow/blob/33363d541851f3017ee96f94ceb328d684ed8360/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py#L594 I am looking into a way if this typing can be handled a bit more better (without using `cast`). Sorry, my progress is very slow since past months due to bandwidth limit. I will try to address the the review feedback by this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
