dstandish commented on a change in pull request #6886: [AIRFLOW-6327]
http_hook: Accept json= parameter for payload
URL: https://github.com/apache/airflow/pull/6886#discussion_r362170041
##########
File path: airflow/hooks/http_hook.py
##########
@@ -123,6 +127,7 @@ def run(self, endpoint, data=None, headers=None,
extra_options=None):
req = requests.Request(self.method,
url,
data=data,
+ json=json,
Review comment:
hi @baolsen i like your `request_kwargs` approach.
i just offered a suggestion for cleaning up the test. you'll also have to
add `from parameterized import parameterized` if you choose to adopt the
simplification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
