ashb commented on code in PR #67800:
URL: https://github.com/apache/airflow/pull/67800#discussion_r3348412912
##########
airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py:
##########
@@ -2154,6 +2155,19 @@ def setup_method(self):
def teardown_method(self):
clear_db_runs()
+ # ti_heartbeat runs on the async engine. The async engine binds its pool to
+ # the event loop that created it (once per process), but the test harness
+ # builds a fresh FastAPI app and event loop per test, so a pooled
connection
Review Comment:
I wonder what impact re-creating the connection many times will have on
test durations? (Not much for _this_ case, but as we move more things to async?)
Should we look at changing the default event-loop scoping maybe? That also
has draw backs for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
