[
https://issues.apache.org/jira/browse/AIRFLOW-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006045#comment-17006045
]
ASF GitHub Bot commented on AIRFLOW-6359:
-----------------------------------------
kaxil commented on pull request #6978: [AIRFLOW-6359] Make Spark
status_poll_interval explicit
URL: https://github.com/apache/airflow/pull/6978
PR #6909 made this change. The default value should be explicit and
documented. However, this was not the case in the PR. This PR fixes it.
- [x] Description above provides context of the change
- [x] Jira: https://issues.apache.org/jira/browse/AIRFLOW-6410
- [x] Unit tests coverage for changes (not needed for documentation
changes). The current tests already cover it.
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> spark_submit_hook.py polling too frequent
> -----------------------------------------
>
> Key: AIRFLOW-6359
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6359
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 1.10.6
> Reporter: t oo
> Assignee: t oo
> Priority: Major
> Fix For: 1.10.8
>
>
> spark polling every second is too frequent, use config to change to desired
> interval, ie 15 seconds
> contrib/hooks/spark_submit_hook.py Poll spark server at a custom interval
> instead of every second
>
> BEFORE
> Sleep for 1 second as we do not want to spam the cluster
> time.sleep(1)
>
> AFTER
> import airflow
> from airflow import configuration as conf
> Sleep for n second as we do not want to spam the cluster
> _poll_interval = conf.getint('sparksubmit', 'poll_interval')
> time.sleep(_poll_interval)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
