Har1sh-k commented on PR #66751:
URL: https://github.com/apache/airflow/pull/66751#issuecomment-4615380870
Pushed a fix. I dropped the reject-regex and instead quote the identifiers
that get interpolated into the Presto SELECT: the table in `FROM` (quoting each
component of a `db.table` name), the partition columns in `WHERE`, and the
column names and their aliases in the projection (`COUNT(col)`, `SUM(col)`, and
so on). Plain identifiers are still emitted unquoted like before, and anything
with dashes or spaces is double-quoted with embedded quotes doubled, so a
column like `weird-col` now renders as `COUNT("weird-col")` instead of failing.
Added a unit test covering the special-character column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
