Suraj-kumar00 commented on code in PR #67947:
URL: https://github.com/apache/airflow/pull/67947#discussion_r3351118220
##########
airflow-ctl-tests/tests/airflowctl_tests/test_airflowctl_commands.py:
##########
@@ -94,12 +94,17 @@ def date_param():
"dags update example_bash_operator --no-is-paused",
# Dag Run commands
"dagrun list --dag-id example_bash_operator --state success --limit=1",
- # XCom commands - need a Dag run with completed tasks
- 'xcom add example_bash_operator "manual__{date_param}" runme_0 {xcom_key}
\'{{"test": "value"}}\'',
- 'xcom get example_bash_operator "manual__{date_param}" runme_0 {xcom_key}',
- 'xcom list example_bash_operator "manual__{date_param}" runme_0',
- 'xcom edit example_bash_operator "manual__{date_param}" runme_0 {xcom_key}
\'{{"updated": "value"}}\'',
- 'xcom delete example_bash_operator "manual__{date_param}" runme_0
{xcom_key}',
+ # Task Instance commands
+ 'taskinstance list --dag-id=example_bash_operator
--dag-run-id="manual__{date_param}"',
+ 'taskinstance get --dag-id=example_bash_operator
--dag-run-id="manual__{date_param}" --task-id=runme_0',
+ "taskinstance clear --dag-id=example_bash_operator --dry-run",
+ 'taskinstance update --dag-id=example_bash_operator
--dag-run-id="manual__{date_param}" --task-id=runme_0 --new-state=success',
+ # XCom commands - need a DAG run with completed tasks
+ 'xcom add --dag-id=example_bash_operator
--dag-run-id="manual__{date_param}" --task-id=runme_0 --key={xcom_key}
--value=\'{{"test": "value"}}\'',
Review Comment:
Fixed, all required params (dag_id, dag_run_id, task_id, key, value) are now
positional args in the test commands, matching how CommandFactory generates
them. Rebased on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
