amoghrajesh commented on code in PR #67902:
URL: https://github.com/apache/airflow/pull/67902#discussion_r3354973680
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/asset_store.py:
##########
@@ -134,7 +172,13 @@ def set_asset_store(
session: SessionDep,
) -> None:
"""Set an asset store value. Creates or overwrites the key."""
- _get_db_backend().set(AssetScope(asset_id=asset_id), key,
json.dumps(body.value), session=session)
+ _get_db_backend().set_asset_store(
Review Comment:
The `AssertionError` is an internal invariant guard — it only fires if a new
`AssetStoreWriterKind` variant is added without updating the `match` block
in`validate_writer_fields`. That's a developer mistake, not a bad request from
the client, so letting it surface as 500 is the correct behaviour as per me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
