jedcunningham commented on code in PR #67988: URL: https://github.com/apache/airflow/pull/67988#discussion_r3356827388
########## dev/README_RELEASE_HELM_CHART.md: ########## @@ -1169,17 +1172,27 @@ Do not add `-dev` suffix to the version. ## Remove old releases -We should keep the old version a little longer than a day or at least until the updated -``index.yaml`` is published. This is to avoid errors for users who haven't run ``helm repo update``. +ASF release policy requires that the distribution area (``dist/release``) holds only the +latest release; every superseded version must be removed from ``dist/release`` once a new +version is published. The removed releases are not lost -- they remain permanently available +from the archive at https://archive.apache.org/dist/airflow/helm-chart/. See +http://www.apache.org/legal/release-policy.html#when-to-archive -It is probably ok if we leave last 2 versions on release svn repo too. +Do this only *after* the updated ``index.yaml`` has been published (see the step above), so +that users who have not yet run ``helm repo update`` are not left pointing at ``dist/release`` +URLs that now 404 -- it is the published ``index.yaml`` that rewrites old-version URLs to the +archive. + Review Comment: ```suggestion ``` Everyone uses archive now, we don't need to worry about timing of index.yaml at all. ########## dev/README_RELEASE_HELM_CHART.md: ########## @@ -1169,17 +1172,27 @@ Do not add `-dev` suffix to the version. ## Remove old releases -We should keep the old version a little longer than a day or at least until the updated -``index.yaml`` is published. This is to avoid errors for users who haven't run ``helm repo update``. +ASF release policy requires that the distribution area (``dist/release``) holds only the +latest release; every superseded version must be removed from ``dist/release`` once a new +version is published. The removed releases are not lost -- they remain permanently available +from the archive at https://archive.apache.org/dist/airflow/helm-chart/. See +http://www.apache.org/legal/release-policy.html#when-to-archive -It is probably ok if we leave last 2 versions on release svn repo too. +Do this only *after* the updated ``index.yaml`` has been published (see the step above), so +that users who have not yet run ``helm repo update`` are not left pointing at ``dist/release`` +URLs that now 404 -- it is the published ``index.yaml`` that rewrites old-version URLs to the +archive. + +The snippet below removes every version except the one you just released (``${VERSION}``): ```shell # http://www.apache.org/legal/release-policy.html#when-to-archive -cd cd ${AIRFLOW_REPO_ROOT}/asf-dist/release/airflow/helm-chart -export PREVIOUS_VERSION=1.0.0 -svn rm ${PREVIOUS_VERSION} -svn commit -m "Remove old Helm Chart release: ${PREVIOUS_VERSION}" +cd "${AIRFLOW_SVN_RELEASE_HELM}" +svn update +for old_version in $(svn ls | sed 's:/$::' | grep -vx "${VERSION}"); do + svn rm "${old_version}" +done +svn commit -m "Remove superseded Helm Chart releases, keeping only ${VERSION} in dist/release per ASF release policy (older releases remain available from https://archive.apache.org/dist/airflow/helm-chart/)" Review Comment: We don't need this detail in every commit message. ```suggestion svn commit -m "Remove superseded Helm Chart releases" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
