1fanwang commented on code in PR #66810:
URL: https://github.com/apache/airflow/pull/66810#discussion_r3359378566
##########
airflow-core/src/airflow/jobs/scheduler_job_runner.py:
##########
@@ -2756,16 +2761,31 @@ def _emit_pool_metrics(self, session: Session =
NEW_SESSION) -> None:
slot_stats["open"],
tags={"pool_name": normalized_pool_name},
)
+ stats.timing(
+ "pool.open_slots.distribution",
+ slot_stats["open"],
+ tags={"pool_name": normalized_pool_name},
+ )
stats.gauge(
"pool.queued_slots",
slot_stats["queued"],
tags={"pool_name": normalized_pool_name},
)
+ stats.timing(
+ "pool.queued_slots.distribution",
+ slot_stats["queued"],
+ tags={"pool_name": normalized_pool_name},
+ )
stats.gauge(
"pool.running_slots",
slot_stats["running"],
tags={"pool_name": normalized_pool_name},
)
+ stats.timing(
+ "pool.running_slots.distribution",
+ slot_stats["running"],
+ tags={"pool_name": normalized_pool_name},
+ )
stats.gauge(
Review Comment:
No good reason — oversight. Added both in fb84642
(`pool.deferred_slots.distribution` + `pool.scheduled_slots.distribution`),
with the YAML entries and the test extended to assert gauge+histogram pairs for
all five slot states. The PR description's Tests section now has a live statsd
capture showing all five `.distribution` lines on the wire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
