potiuk commented on PR #67868:
URL: https://github.com/apache/airflow/pull/67868#issuecomment-4627078131
Thanks @ashb — reworked based on your feedback. Rather than removing the
field (which, as you noted, would be a breaking schema change for downstream
consumers), `TriggerResponse.kwargs` is now **retained** in the schema but
always returned empty as `"{}"`.
Addressing your specific points:
- **Not breaking:** the field stays and keeps its existing `str` type, so
the OpenAPI schema is unchanged — no missing-property errors for consumers, and
no regenerated spec/UI client.
- **On the `str()` concern:** I kept it a string deliberately (it has always
been one) rather than switching to an object, to avoid a schema type change.
Since the value is now a constant `"{}"`, it no longer leaks the real kwargs
and no longer depends on stringifying a meaningful dict — `"{}"` is exactly
what an empty-kwargs trigger already serialized to under the old `str()`
behavior.
- The triggerer still decrypts and uses the real kwargs at runtime; only the
API representation is emptied.
Added a unit test asserting sensitive kwargs are redacted to `"{}"`, and
updated the newsfragment. Could you take another look when you get a chance?
---
Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
