xchwan opened a new pull request, #68066:
URL: https://github.com/apache/airflow/pull/68066
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #35442
-->
### Added `test_base.py`
Tests for `BaseGoogleLink` — the shared base class all Google links inherit
from. Covers:
- `xcom_key` property returns `self.key`
- `persist()` pushes the correct key/value to XCom
- `get_config()` returns `None` when no config found; merges
`extra_links_params` from operator with XCom value; XCom takes precedence over
operator params
- `_format_link()` prepends `BASE_LINK` for relative paths; returns `""` on
missing format key; returns absolute URLs unchanged
- `get_link()` returns `""` when no config; passes through existing http
URLs without re-formatting; formats URL from config
### Added `test_bigquery.py`
Tests for `BigQueryDatasetLink`, `BigQueryTableLink`,
`BigQueryJobDetailLink`. Each class covers:
- Class attributes (`key`, `name`, `format_str`)
- `persist()` calls `xcom_push` with correct key and values
- `_format_link()` produces the expected URL
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (claude sonnet 4.6)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
