srchilukoori commented on PR #65840:
URL: https://github.com/apache/airflow/pull/65840#issuecomment-4632677367
> Two specifics to fold into the process question above:
>
> **1. Version downgrade.** This moves the theme from the previously-pinned
`0.3.10` (old URL + `uv.lock`) to `0.3.9` —
`docs-theme/sphinx_airflow_theme/__init__.py` sets `__version__ = "0.3.9"` and
the dep is relaxed to `>=0.3.9`. Since `fetch_theme_assets.py` derives the
wheel URL from `__version__`, the docs build would fetch the **0.3.9** assets,
not 0.3.10. If 0.3.10 carried fixes that's a silent regression — please bump
`__version__` to `0.3.10` (and keep `>=0.3.10`) unless the downgrade is
deliberate.
>
> **2. Description vs. diff.** The PR body lists edits to
`selective_checks.py` ("removed redundant `^docs-theme` pattern") and
`.pre-commit-config.yaml` ("removed `_gen/` exclusions"), but neither file is
in the diff. Were they dropped on a rebase? The `.pre-commit-config.yaml`
change looks load-bearing now that `_gen/` is untracked — if the old `_gen/`
exclusions remain while the dir is gone, please reconcile.
>
> > _This review was drafted by an AI-assisted tool and confirmed by an
Apache Airflow maintainer. The findings below are observations, not blockers;
an Apache Airflow maintainer — a real person — will take the next look at the
PR. If you think a finding is mis-applied, please reply on the PR and a
maintainer will weigh in._
> > _More on how Apache Airflow handles maintainer review:_
[contributing-docs/05_pull_requests.rst](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst).
>
> Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting
@potiuk Updated the version to 0.3.10, and it will be auto updated in future
builds, once the PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
