jscheffl commented on code in PR #67675:
URL: https://github.com/apache/airflow/pull/67675#discussion_r3363840029


##########
chart/values.yaml:
##########
@@ -331,6 +331,55 @@ ingress:
     # The Ingress Class for the PgBouncer Ingress
     ingressClassName: ""
 
+# Kubernetes Gateway API (HTTPRoute) configuration.
+# Requires the Gateway API CRDs to be installed in the cluster
+# (https://gateway-api.sigs.k8s.io/guides/#installing-gateway-api).
+# The HTTPRoute resources reference an externally managed Gateway via 
`parentRefs`.
+httpRoute:
+  # Enable all HTTPRoute resources (deprecated, use
+  #   `httpRoute.apiServer.enabled`,
+  # instead). Reserved for future expansion to flower/statsd/pgbouncer.
+  enabled: ~

Review Comment:
   Please do not add new deprecated parameters. In ingress we just keep them 
for backwards compatibility. Actually in 
https://github.com/apache/airflow/pull/68043 I am attempting in parallel to 
remove them. Please change the contribution alongside such that no new 
deprecations are added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to