kaxil commented on code in PR #67717:
URL: https://github.com/apache/airflow/pull/67717#discussion_r3366361035
##########
airflow-core/src/airflow/timetables/_cron.py:
##########
@@ -137,12 +137,27 @@ def __hash__(self):
def summary(self) -> str:
return self._expression
+ @property
+ def timezone(self) -> Timezone | FixedTimezone:
Review Comment:
This public `timezone` property has no consumers in core. Per the PR
description it was added so `dag_clear` could read the timetable timezone, but
after the switch to the polymorphic `get_partition_day_bound`, `dag_clear` no
longer reads `.timezone` and the `CronMixin.get_partition_day_bound` override
reaches `self._timezone` directly. The `timetable.timezone` reads in
`serialization/encoders.py` (367/377/386) are on the SDK timetables (imported
from `airflow.sdk`), which already expose their own `timezone`, not this core
`CronMixin`. Looks safe to drop, and the PR-description bullet justifying it is
now stale -- unless you'd rather keep it for core/SDK API symmetry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
