Dev-iL commented on code in PR #67800:
URL: https://github.com/apache/airflow/pull/67800#discussion_r3369000935
##########
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py:
##########
@@ -761,10 +761,10 @@ def ti_skip_downstream(
]
),
)
-def ti_heartbeat(
+async def ti_heartbeat(
task_instance_id: UUID,
ti_payload: TIHeartbeatInfo,
- session: SessionDep,
+ session: AsyncSessionDep,
Review Comment:
Added `scope="function"` to `AsyncSessionDep` so the commit runs before the
response, same as `SessionDep`. Added a regression test that forces a commit
failure and asserts the worker gets a 500 (not a silent 204) and 204 without
the kwarg. Also fixed the "mirrors the sync dependency exactly" line in the
description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
