sjyangkevin commented on code in PR #67449: URL: https://github.com/apache/airflow/pull/67449#discussion_r3370032050
########## providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_types.py: ########## @@ -69,10 +69,10 @@ class KubernetesWatch(NamedTuple): class KubernetesJob(NamedTuple): - """Job definition for Kubernetes execution.""" + """Job definition for Kubernetes execution (task or callback).""" - key: TaskInstanceKey - command: Sequence[str] + key: WorkloadKey + command: Sequence[Any] Review Comment: Created a `WorkloadCommand` to implement the same handle. The reason not name is as `CommandType` is because at L92, there is already a definition. Not sure if that would be safe to remove, but it might cause some shadowing when using the same name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
