sjyangkevin opened a new pull request, #68195:
URL: https://github.com/apache/airflow/pull/68195
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
* related: #58248
* related: #67449
When a Dag defines a deadline alert, the alert is stored in its own
`deadline_alert` table on write, and
`SerializedDagModel._generate_deadline_uuids` rewrites the serialized Dag's
`deadline` field from a list of encoded dicts into a list of UUID strings
pointing at those rows. However, `schema.json` only allowed `deadline` to be a
dict, an array of dicts, or null. As a result, validating the stored serialized
Dag for any deadline-bearing Dag fails with something like:
```
FAILED
airflow-core/tests/unit/models/test_serialized_dag.py::TestSerializedDagModel::test_write_dag[compress-serialized_dags]
- jsonschema.exceptions.ValidationError:
['019ea3de-70d1-77ec-82b1-0dceeb508be5'] is not valid under any of the given
schemas
Failed validating 'anyOf' in
schema['allOf'][0]['properties']['dag']['properties']['deadline']:
{'anyOf': [{'$ref': '#/definitions/dict'},
{'items': {'$ref': '#/definitions/dict'}, 'type': 'array'},
{'type': 'null'}]}
On instance['dag']['deadline']:
['019ea3de-70d1-77ec-82b1-0dceeb508be5']
```
**Fix**
- Adds an `array` of `string` option to the `deadline` schema so it accepts
the persisted UUID-reference format.
- Adds a regression test that writes a deadline-bearing Dag and asserts the
stored data passes schema validation, guarding against the schema and storage
format drifting apart again.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Generated-by: [Claude Code (Opus 4.8)] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
