amoghrajesh opened a new pull request, #68218:
URL: https://github.com/apache/airflow/pull/68218
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### What
`task_store` rows have an `expires_at` column for per-key TTL, but they also
need to be included in `airflow db clean`, so they can be both removed manually
via `airflow state-store cleanup-task-store` and by db clean. This PR wires
`task_store` into the standard cleanup infrastructure.
`asset_store` was intentionally excluded cos it has no `expires_at` column
because it holds long lived current state for assets (not ephemeral per-run
data). Rows are cleaned implicitly via `ON DELETE CASCADE` when the asset
itself is deleted.
### Current behaviour
`task_store` rows are never pruned by `airflow db clean`. The only removal
path is the manual CLI command `airflow state-store cleanup-task-store`, which
is easy to miss sometimes and mainly so for people using the cleanup dags like
this one: https://www.astronomer.io/docs/learn/2.x/cleanup-dag-tutorial
### Proposed change
- Added `task_store` to `dag_run`'s `dependent_tables` list so it is
cascaded when a DAG run row is cleaned.
- Added a `_TableConfig` entry for `task_store` using `expires_at` as the
recency column (not `updated_at`) so that `NULL` (`expires_at` = NEVER_EXPIRE)
rows are correctly skipped — SQL evaluates `NULL < timestamp` as `NULL`, not
`TRUE`, so they are never matched by the `WHERE` clause.
- Added `TestTaskStoreCleanup` verifying: expired rows are deleted,
NEVER_EXPIRE rows (`expires_at=NULL`) survive, and not-yet-expired rows survive.
### Changes of Note
`expires_at` is the correct recency column here. Using `updated_at` would
incorrectly delete NEVER_EXPIRE rows because those rows are regularly updated
when retries write state. `expires_at=NULL` means "keep until the DAG run is
cleaned up via FK cascade", which is what we want.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
