xBis7 commented on code in PR #68213:
URL: https://github.com/apache/airflow/pull/68213#discussion_r3372661578
##########
task-sdk/src/airflow/sdk/bases/resumablejobmixin.py:
##########
@@ -101,29 +107,56 @@ def execute_resumable(self, context: Context) -> Any:
Closing this window would require atomic "submit + persist", which is
not possible across
an external system boundary.
"""
- task_store = context.get("task_store")
+ operator_tag = {"operator": type(self).__name__}
+
+ with tracer.start_as_current_span("resumable_job.resume_decision") as
span:
+ span.set_attribute("operator", type(self).__name__)
+ span.set_attribute("resumable.external_id_key",
self.external_id_key)
+
+ task_store = context.get("task_store")
+
+ if task_store is None:
+ span.set_attribute("resumable.decision", "no_task_store")
+ else:
+ external_id = task_store.get(self.external_id_key)
+ if external_id:
+ incr("resumable_job.reconnect_attempt", tags=operator_tag)
Review Comment:
There is a pre-commit check that enforces it
https://github.com/astronomer/airflow/blob/aip-103-debugability-observability-traces-metrics/.pre-commit-config.yaml#L839-L846
This part should have failed but it didn't.
https://github.com/apache/airflow/actions/runs/27127188179/job/80065337011#step:6:191
The check looks for `stats.*` calls. You used `incr` directly, and that's
why it didn't recognize the additions as metric calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
