ashb commented on issue #68240:
URL: https://github.com/apache/airflow/issues/68240#issuecomment-4651053451

   bug 1. Not sure about -- I think that the logger's contextvar (i.e. what is 
added to every record via structlog) already contains the task id et al.
   
   bug 2. If it's possible, the best fix is to filter/read based on the ti.id, 
as that is unique per try (i.e. retries). Neither run_id nor the date changes 
when a retry happens, but reading task logs expects to just get logs for a 
single try at a time. However just naively changing this filter will stop all 
old/already written logs (if they work _at all today_) from being found anymore
   
   bug 3. Yeah possible. 
   
   This should be done as three separate PRs, not a single one, so do not use 
the `closes` keyword, only `relates`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to