SameerMesiah97 commented on code in PR #68134:
URL: https://github.com/apache/airflow/pull/68134#discussion_r3375848750
##########
providers/apache/spark/tests/unit/apache/spark/hooks/test_spark_submit.py:
##########
@@ -941,17 +941,24 @@ def test_process_spark_submit_log_k8s_spark_3(self):
# Then
assert hook._spark_exit_code == 999
- def test_process_spark_submit_log_k8s_submission_id_format(self):
+ @pytest.mark.parametrize(
+ "pod_name",
+ [
+ "arrow-spark-c8e2e29e73db9c93-driver",
+ "victim-driver-foo-abc-driver",
Review Comment:
It would not hurt to add a few additional cases here to exercise the
boundary conditions:
# Minimal valid name
"a-driver",
# Starts with a digit
"123-driver",
# Mix of letters, digits and hyphens
"a-1-b-2-c-3-driver",
# Multiple embedded "driver" tokens
"driver-foo-driver-bar-driver",
# Realistic Spark-generated style name
"spark-pi-7c4d6f8a-driver",
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
