jscheffl commented on code in PR #68043:
URL: https://github.com/apache/airflow/pull/68043#discussion_r3376355767
##########
chart/tests/helm_tests/apiserver/test_ingress_apiserver.py:
##########
@@ -133,41 +62,20 @@ def test_should_ingress_host_entry_not_exist(self):
assert not jmespath.search("spec.rules[*].host", docs[0])
@pytest.mark.parametrize(
- ("global_value", "api_server_value", "expected"),
+ ("api_server_value", "expected"),
[
- (None, None, False),
- (None, False, False),
- (None, True, True),
- (False, None, False),
- (True, None, True),
- (False, True, True), # We will deploy it if _either_ are true
- (True, False, True),
+ (None, False),
+ (False, False),
+ (True, True),
Review Comment:
Will not work. First item in the tuple is the input, second is the expected
outcome. Generating with `None` will product `False` as check result (meaning
no API Server ingress created).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
